RC_Channel: options in alphabetical order #25963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is purely a doc change so it looks better in MP, right? |
|
Yes, that's right. It has no functional change in terms of the flight code. It's just for the GCSs. |
|
will require considerable wiki work on this page: common-auxiliary-functions.rst, but its a good change...have made a suggestion while we are at it. |
Hwurzburg
requested changes
Jan 12, 2024
| @@ -104,146 +104,147 @@ const AP_Param::GroupInfo RC_Channel::var_info[] = { | |||
| // @User: Advanced | |||
| AP_GROUPINFO("DZ", 5, RC_Channel, dead_zone, 0), | |||
|
|
|||
|
|
|||
| // @Param: OPTION | |||
| // @DisplayName: RC input option | |||
| // @Description: Function assigned to this RC channel | |||
There was a problem hiding this comment.
Suggested change
| // @Description: Function assigned to this RC channel | |
| // @Description: Function assigned to this RC channel. Normally intended as a 2 or 3 position switch, functions in the 200/300 ranges are normally intended for continuous input range control. |
|
I wonder if we could just have the param parser do this for us automatically.... |
we could have an optional "@SortedOptions" line which would cause it sort |
|
I'm happy with the SortedOptions idea if we're happy not to have the flight modes at the top. |
|
An alternative change is here #25996 |
|
Closing in favour of PeterB's PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our list of RCx_OPTION parameter values is very long and users struggle to find what they are looking for.
This PR reorders them mostly in alphabetical order with some exceptions:
There are some small issues that I could have fixed but put off for a follow-up PR to keep it easier to verify and merge:
a. some lines still have multiple items on them (e.g. "300:Scripting1, 301:Scripting2.." and "166:Camera Record Video, 167:Camera Zoom)
b. some items are badly named, (e.g. "use Custom Controller")
c. some are used to define the channel is used for control (e.g. Roll, Walking Height). We could group these, perhaps below the modes
I have carefully verified that no items have been lost in this change. I asked ChatGPT to do it first but it failed so I resorted to a spreadsheet with multiple cross checks.