AC_Fence: ensure fencepoint protocol not compiled in if not HAL_GCS_ENABLED #26235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be fair we should consider pulling in commits from this pr #25262 |
| @@ -11,5 +13,5 @@ | |||
| #endif | |||
|
|
|||
| #ifndef AC_POLYFENCE_FENCE_POINT_PROTOCOL_SUPPORT | |||
| #define AC_POLYFENCE_FENCE_POINT_PROTOCOL_SUPPORT AP_FENCE_ENABLED | |||
| #define AC_POLYFENCE_FENCE_POINT_PROTOCOL_SUPPORT HAL_GCS_ENABLED && AP_FENCE_ENABLED | |||
There was a problem hiding this comment.
Won't the GCS_SEND_TEXT macros take care of the case when HAL_GCS_ENABLED is zero?
Is this change really needed?
There was a problem hiding this comment.
There are other bits in there that aren't gcs().send_text.
Also, the fencepoint protocol is mavlink, so it makes sense to gate it.
There was a problem hiding this comment.
I need coffee, sorry. I read Fence instead of Fencepoint. :)
Carry on, nothing to see here. :)
…NABLED also use GCS_SEND_TEXT a bit
peterbarker
force-pushed
the
pr/fence-hal-gcs-enabled
branch
from
6044dc1
to
6b13a49
Compare
I've rebased on top of a cherry-picked patch from that PR and force-pushed this branch |
tridge
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also use GCS_SEND_TEXT a bit