Correct Periph compilation if Check Firmware is not enabled #26543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is enabled by default on periph. |
tridge
requested changes
Mar 18, 2024
| @@ -127,7 +127,9 @@ void AP_Periph_FW::init() | |||
| logger.init(g.log_bitmask, log_structure, ARRAY_SIZE(log_structure)); | |||
| #endif | |||
|
|
|||
| #if AP_CHECK_FIRMWARE_ENABLED | |||
There was a problem hiding this comment.
I think we should assert that AP_CHECK_FIRMWARE_ENABLED is enabled in AP_Periph. It is unsafe to have a peripheral without it. We need the crc checking or the user can brick their board
There was a problem hiding this comment.
I've added it as a separate default in defaults_periph.h to make sure it's turned on.
There was a problem hiding this comment.
why not an assert? periph just won't work properly without it
the typedef won't exist in that case
peterbarker
force-pushed
the
pr/check-firmware-compilation-fixes
branch
from
7eb0339
to
72bc292
Compare
peterbarker
commented
Mar 19, 2024
| @@ -127,7 +127,9 @@ void AP_Periph_FW::init() | |||
| logger.init(g.log_bitmask, log_structure, ARRAY_SIZE(log_structure)); | |||
| #endif | |||
|
|
|||
| #if AP_CHECK_FIRMWARE_ENABLED | |||
There was a problem hiding this comment.
I've added it as a separate default in defaults_periph.h to make sure it's turned on.
tridge
requested changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app_descriptor is guarded behing AP_CHECK_FIRMWARE_ENABLED, and that's only enabled by default when AP_OPENDRONEID_ENABLED is true.
Given the app descriptor seems to contain useful information useful in places where AP_OPENDRONEID_ENABLED is false, this is maybe a bit unfortunate.