Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROMFS: avoid decompressing in stat() #26558

Merged
merged 2 commits into from Mar 19, 2024
Merged

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Mar 18, 2024

This makes ROMFS much more efficient. It is particularly important when serving up javascript and html for the web server as we use if-modified-since to avoid re-sending files to the client. Without this changes we decompress every time.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding the comparison against nullptr.

@peterbarker peterbarker merged commit 8763084 into ArduPilot:master Mar 19, 2024
91 checks passed
@rmackay9
Copy link
Contributor

I could not add this to 4.5.2-beta1 due to a merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending
Development

Successfully merging this pull request may close these issues.

None yet

4 participants