AP_Logger: avoid logging dma.txt for normal builds #26559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logging of dma.txt currently does no good as the first time you read it you get no content. It then enables statistics in the shared_dma code which makes all DMA operations slower, so all we are doing is making DMA slower
andyp1per
approved these changes
Mar 18, 2024
peterbarker
approved these changes
Mar 18, 2024
|
As discussed it might be useful to have this as a custom build server option instead of a build option. That would make it more accessible for those without a build environment setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging of dma.txt currently does no good as the first time you read it you get no content. It then enables statistics in the shared_dma code which makes all DMA operations slower, so all we are doing is making DMA slower