Rover: Notify lat and long to the seventh decimal place #27020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilcarlucas
approved these changes
May 8, 2024
khancyr
approved these changes
Jun 3, 2024
peterbarker
approved these changes
Jul 25, 2024
peterbarker
force-pushed
the
AP_Notify_lat_and_long_to_the_seventh_decimal_place
branch
from
7cb12ea
to
3ade1bd
Compare
|
Does it actually display all the digits? I suspect it does in which case I should do the same in the recent slung payload simulator. |
I haven't provoked it to do so, but we may as well give it every chance. |
tridge
reviewed
Jul 29, 2024
| @@ -33,7 +33,7 @@ bool Rover::set_home(const Location& loc, bool lock) | |||
| mode_auto.mission.write_home_to_storage(); | |||
|
|
|||
| // send text of home position to ground stations | |||
| gcs().send_text(MAV_SEVERITY_INFO, "Set HOME to %.6f %.6f at %.2fm", | |||
| gcs().send_text(MAV_SEVERITY_INFO, "Set HOME to %.7f %.7f at %.2fm", | |||
There was a problem hiding this comment.
this won't work on ChibiOS at least, possibly not on SITL too, we go via a float inside the printf engine
|
We think this doesn't actually work. Remember to provide testing results! We discussed on the dev call that what we need is a function somewhere that allows printing lat,lon values to the required number of decimal places |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seventh decimal place corresponds to centimeters.