Copter: Enable processing #27134
Merged
Copter: Enable processing #27134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
May 22, 2024
| @@ -409,10 +409,9 @@ bool ModeGuided::get_wp(Location& destination) const | |||
| destination = Location(guided_pos_target_cm.tofloat(), guided_pos_terrain_alt ? Location::AltFrame::ABOVE_TERRAIN : Location::AltFrame::ABOVE_ORIGIN); | |||
| return true; | |||
| default: | |||
| return false; | |||
| break; | |||
There was a problem hiding this comment.
There should be no default here - we should never be in an invalid SubMode!
There was a problem hiding this comment.
@peterbarker san.
I have described all the definitions.
muramura
force-pushed
the
AP_Enable_processing
branch
from
9b67e71
to
adc7e52
Compare
IamPete1
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This process will never be executed, so I will enable it.
I believe that processes that are never executed are unnecessary.