✨ New TextField With form-labeling support
#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
eunicekokor
approved these changes
Feb 23, 2022
stories/TextField.stories.tsx
Outdated
| decorators: [withDesign], | ||
| parameters: { | ||
| controls: { expanded: true }, | ||
| // design: { |
Contributor
There was a problem hiding this comment.
any reason why this is commented out?
Collaborator
Author
There was a problem hiding this comment.
No, I was having trouble with the integration. Let me try again
mikeldking
force-pushed
the
43-input-field
branch
from
2e7b515 to
e0ef768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #43
Does not support auto-margins via
Formwhich is next. This will be done as part ofFormas we need to support inline input fields.Also makes
addona generic interface and addsFieldLabelsupport that can be used to label form items.