Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #3889

Closed
wants to merge 3 commits into from
Closed

chore: update dependencies #3889

wants to merge 3 commits into from

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jul 13, 2020

Will need to check what the type-fest error is about because it causes tests to fail.

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2020

This pull request introduces 1 alert when merging ac3acc9 into 381e9c7 - view on LGTM.com

new alerts:

  • 1 for Missing variable declaration

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #3889 into develop will increase coverage by 3.81%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3889      +/-   ##
===========================================
+ Coverage     9.87%   13.68%   +3.81%     
===========================================
  Files          618      628      +10     
  Lines        14433    14529      +96     
  Branches      1725     1728       +3     
===========================================
+ Hits          1425     1989     +564     
+ Misses       12902    12425     -477     
- Partials       106      115       +9     
Flag Coverage Δ
#functional 6.77% <6.66%> (?)
#integration 9.84% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-cli/src/services/environment.ts 0.00% <0.00%> (ø)
...s/core-kernel/src/services/config/drivers/local.ts 0.00% <0.00%> (ø)
...ges/core-state/src/wallets/utils/search-entries.ts 0.00% <ø> (ø)
packages/core/src/commands/env-get.ts 0.00% <0.00%> (ø)
packages/core/src/commands/env-list.ts 0.00% <0.00%> (ø)
...ges/core-test-framework/src/app/generators/core.ts 74.19% <50.00%> (+7.52%) ⬆️
packages/core-api/src/plugins/rate-limit.ts 83.33% <100.00%> (ø)
packages/core-p2p/src/enums.ts 100.00% <0.00%> (ø)
packages/core-forger/src/client.ts 0.00% <0.00%> (ø)
packages/core-p2p/src/listeners.ts 0.00% <0.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381e9c7...b742c12. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants