Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

bug: misaligned wallet details tabs component #1639

Closed
dated opened this issue Jan 30, 2020 · 9 comments · Fixed by #1638
Closed

bug: misaligned wallet details tabs component #1639

dated opened this issue Jan 30, 2020 · 9 comments · Fixed by #1638
Labels
Type: Bug The issue relates to broken or incorrect behaviour.

Comments

@dated
Copy link
Contributor

dated commented Jan 30, 2020

The tabs component on the wallet details is not aligned to the lefthand menu.

image

The root cause is the following css class definition. On first look I couldn't find out why the max-height is adjusted in the first place, removing that line didn't have any negative side effects, might need more investigating.

  .App__page {
    @apply .min-h-full;
    max-height: calc(100vh - 5rem);
  }
@ghost
Copy link

ghost commented Jan 30, 2020

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@dav1app
Copy link
Contributor

dav1app commented Feb 11, 2020

I tried to reproduce that on the latest devel branch and it seems to be fixed.

image

If it is not, just let me know.

@dav1app dav1app closed this as completed Feb 11, 2020
@ghost
Copy link

ghost commented Feb 11, 2020

This issue has been closed. If you wish to re-open it please provide additional information.

@brenopolanski
Copy link
Contributor

@davimello28 It's possible to reproduce this issue by resizing the wallet height to <640px.

Screenshot from 2020-02-11 08-52-39

Solution:

Add to .AppSidemenu--vertical a height of 100%.

Peek 2020-02-11 09-14

@dated can you test it ---^ and tell me what you think.

@brenopolanski brenopolanski reopened this Feb 11, 2020
@ghost
Copy link

ghost commented Feb 11, 2020

This issue has now been re-opened. If applicable please provide additional information as requested by one of the reviewers.

@dated
Copy link
Contributor Author

dated commented Feb 11, 2020

That certainly fixes the sidebar 👍 but is a different issue. I forgot to mention that the misalignment happens at a width < 992 px

image

Which is fixed only by setting the max-height of the .App__page class to 100vh, but I haven't looked around for possible side effects yet.

@dated
Copy link
Contributor Author

dated commented Feb 11, 2020

Added the fixes for the sidebar and wallet details component to #1638 in 850437d and 8eae98c @brenopolanski. I didn't observe any side effects.

@dav1app dav1app added the Type: Bug The issue relates to broken or incorrect behaviour. label Feb 12, 2020
@dav1app dav1app linked a pull request Feb 12, 2020 that will close this issue
3 tasks
@dav1app
Copy link
Contributor

dav1app commented Feb 18, 2020

Also this is happening to me when I have the height adjusted.

image

Edit: Ignore me. This seems to be related to the PRO theme.

@ghost
Copy link

ghost commented Feb 26, 2020

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug The issue relates to broken or incorrect behaviour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants