This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
refactor: simplify blurred modal backdrop & ui tweaks #1638
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a6ce40e
refactor: simplify blurred modal backdrop
dated 9c240b8
refactor: remove offset from header from height
dated 880e053
fix: rounded borders on wallet details
dated b0c6a21
Merge branch 'develop' into fix/blurred-backdrop
dated 47c2b86
Merge branch 'develop' into fix/blurred-backdrop
dated f9ba8fb
Merge branch 'develop' into fix/blurred-backdrop
dated 850437d
fix: app sidemenu height
dated 8eae98c
fix: wallet details misalignment
dated 6eb4b85
Merge branch 'fix/blurred-backdrop' of https://github.com/dated/deskt…
dated dc1fcf1
refactor: remove blur handling from ButtonDropdown component
dated 85700dc
refactor: reposition button dropdown when resizing
dated f5f02cc
Merge branch 'develop' into fix/blurred-backdrop
dav1app 6698e3f
Merge branch 'develop' into fix/blurred-backdrop
dated 466c816
Merge branch 'develop' into fix/blurred-backdrop
faustbrian f126b88
Merge branch 'develop' into fix/blurred-backdrop
dated 51b8d42
Merge branch 'develop' into fix/blurred-backdrop
faustbrian 06fa4fa
chore: add backdrop-filter to ModalCloseConfirmation component
dated 12c9656
Merge branch 'develop' into fix/blurred-backdrop
alexbarnsley b942112
Merge branch 'develop' into fix/blurred-backdrop
alexbarnsley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting the message on my devtools console:
Property or method "hasBlurFilter" is not defined on the instance but referenced during render.
Because ofhasBlurFilter
here:desktop-wallet/src/renderer/App.vue
Line 83 in 6eb4b85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the
button-dropdown
portal got added in one of the merges, I'll need to take a look at how it uses the blur class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks like the
blur
on the button dropdown can be safely removed. Strangely the button dropdown wasn't positioned correctly for me during development (this.$refs.buttonDropdown
always beingundefined
) while it displays correctly on 2.8.0, therefore I added a resize handler to also reposition the dropdown while it is open. @alexbarnsley could you have a look at this also? In particular 85700dc which adds the resize handler.