This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 191
refactor: replace Avatar
component in all designs
#2394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: High
More than 256 lines changed.
Type: Refactor
The pull request improves or enhances an existing implementation.
Status: In Progress
The issue or pull request is being worked on.
labels
Jul 7, 2020
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2394 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 226 +202
Lines 142 2289 +2147
Branches 18 438 +420
=============================================
+ Hits 142 2289 +2147
Continue to review full report at Codecov.
|
ghost
added
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
and removed
Status: In Progress
The issue or pull request is being worked on.
labels
Jul 7, 2020
faustbrian
approved these changes
Jul 7, 2020
ghost
deleted the
refactor/avatar-ui-guidelines
branch
July 7, 2020 14:59
ghost
removed
the
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
label
Jul 7, 2020
ghost
mentioned this pull request
Jul 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: High
More than 256 lines changed.
Type: Refactor
The pull request improves or enhances an existing implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avatar
lg size to be w-11/h-11, to align withCircle
componentAvatar
component (for usage withBadge
)<Circle avatarId>
withAvatar
in all designsAll designs should be using
Avatar
component instead of oldCircle
blue avatar-ish element.Previews:
Checklist