Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: replace Avatar component in all designs #2394

Merged
merged 18 commits into from
Jul 7, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 7, 2020

Summary

  • Refactor Avatar lg size to be w-11/h-11, to align with Circle component
  • Allow children inside Avatar component (for usage with Badge)
  • Replace <Circle avatarId> with Avatar in all designs

All designs should be using Avatar component instead of old Circle blue avatar-ish element.

Previews:
2020-07-07-162906_844x277_scrot

2020-07-07-162034_802x515_scrot

2020-07-07-162045_1288x546_scrot

2020-07-07-162723_794x711_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #2394 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2394     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       226    +202     
  Lines            142      2289   +2147     
  Branches          18       438    +420     
=============================================
+ Hits             142      2289   +2147     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
... and 250 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea65ec...3e8ebff. Read the comment docs.

@goga-m goga-m marked this pull request as ready for review July 7, 2020 13:46
@goga-m goga-m requested a review from faustbrian as a code owner July 7, 2020 13:46
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jul 7, 2020
@faustbrian faustbrian merged commit 846b6c1 into 3.0-react Jul 7, 2020
@ghost ghost deleted the refactor/avatar-ui-guidelines branch July 7, 2020 14:59
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants