Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: add position prop to Badges component #2397

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Jul 7, 2020

Summary

Refactors the Badge component which now accepts a position property to properly position the badge inside the parent container.

image

Other small UI changes: fixes the spacing in the Network Filters and starts fixing the UI of the Wallet Filters

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner July 7, 2020 20:27
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #2397 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2397     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       226    +202     
  Lines            142      2300   +2158     
  Branches          18       439    +421     
=============================================
+ Hits             142      2300   +2158     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
... and 250 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8830d1...a89e089. Read the comment docs.

@faustbrian faustbrian merged commit 5a22afb into 3.0-react Jul 8, 2020
@ghost ghost deleted the refactor/badges branch July 8, 2020 02:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants