Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: test errors #2473

Merged
merged 3 commits into from
Jul 15, 2020
Merged

fix: test errors #2473

merged 3 commits into from
Jul 15, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 15, 2020

Summary

Fix testing errors:

src/domains/profile/pages/MyRegistrations/MyRegistrations.test.tsx

    console.error node_modules/react-dom/cjs/react-dom-test-utils.development.js:87
      Warning: The callback passed to act(...) function must return undefined, or a Promise. You returned true
 src/domains/wallet/components/MnemonicVerification/MnemonicVerification.test.tsx

    console.error node_modules/react-dom/cjs/react-dom.development.js:88
      Warning: Encountered two children with the same key, `7`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
          in div (at MnemonicVerification.tsx:60)
          in div (at Tabs.tsx:29)
          in Tabs (at MnemonicVerification.tsx:57)
          in MnemonicVerification (at MnemonicVerification.test.tsx:76)
          in EnvironmentProvider (at testing-library.tsx:20)
          in I18nextProvider (at testing-library.tsx:19)
          in WithProviders

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 15, 2020 08:06
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #2473 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2473     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       265    +241     
  Lines            142      2634   +2492     
  Branches          18       489    +471     
=============================================
+ Hits             142      2634   +2492     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afcbfd2...d725b9c. Read the comment docs.

@faustbrian faustbrian merged commit 489659d into 3.0-react Jul 15, 2020
@ghost ghost deleted the fix/test-errors branch July 15, 2020 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants