Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement verify message #2516

Merged
merged 15 commits into from
Jul 23, 2020
Merged

feat: implement verify message #2516

merged 15 commits into from
Jul 23, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 22, 2020 •
edited
Loading

Summary

Implement verify message functionality
https://trello.com/c/o6l0CT0w/109-implement-message-verifying

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 22, 2020 14:28
@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jul 22, 2020
@goga-m goga-m marked this pull request as draft July 22, 2020 14:29
@goga-m goga-m marked this pull request as ready for review July 22, 2020 14:48
@faustbrian
Copy link
Contributor

@goga-m failing tests

@goga-m goga-m marked this pull request as draft July 23, 2020 07:48
@goga-m goga-m marked this pull request as ready for review July 23, 2020 08:56
@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited
Loading

Codecov Report

Merging #2516 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2516     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       266    +242     
  Lines            142      2827   +2685     
  Branches          18       509    +491     
=============================================
+ Hits             142      2827   +2685
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 287 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd513a5...9f8e943. Read the comment docs.

@goga-m
Copy link
Contributor Author

goga-m commented Jul 23, 2020

@faustbrian just checked locally and all specs pass :hmhm

@faustbrian faustbrian merged commit 5753a28 into 3.0-react Jul 23, 2020
@ghost ghost deleted the feat/implement-verify-message branch July 23, 2020 12:00
@ghost ghost mentioned this pull request Jul 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees
No one assigned
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goga-m @faustbrian