Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement contact deletion #2519

Merged
merged 9 commits into from
Jul 23, 2020
Merged

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 23, 2020

Summary

https://trello.com/c/ORhQrO9o/110-implement-contact-deleting

  • Add implementation for contact deletion in DeleteContact standalone component
  • Add functionality for contact deletion in Contacts page.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 23, 2020 13:46
@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #2519 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2519     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       266    +242     
  Lines            142      2844   +2702     
  Branches          18       511    +493     
=============================================
+ Hits             142      2844   +2702     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 287 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5753a28...2903d8f. Read the comment docs.

@faustbrian
Copy link
Contributor

@goga-m build fails

@faustbrian faustbrian merged commit 2e32fcc into 3.0-react Jul 23, 2020
@ghost ghost deleted the feat/implement-delete-contact branch July 23, 2020 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants