Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: sync delegates in background #2700

Merged
merged 70 commits into from
Aug 28, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

  • Trigger a background job for sync delegates when a profile is selected using electron ipc as worker

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Aug 20, 2020
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Aug 20, 2020
@faustbrian
Copy link
Contributor

@clucasalcantara After #2715 is merged you can use usedCoinsWithNetworks to get a list of all coins and wallets that are used. Then you can use those to create promises of env.coins().syncDelegates(coin, network) and resolve them with Promise.allSettled.

This should ideally be done before the env.boot() method is called so that some requests are already cached and afterwards this should be done in the background.

@goga-m goga-m mentioned this pull request Aug 27, 2020
3 tasks
@faustbrian faustbrian merged commit f1c6dd1 into 3.0-react Aug 28, 2020
@ghost ghost deleted the feat/sync-delegates-in-background branch August 28, 2020 03:00
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants