Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: flush wallet transactions #2918

Merged
merged 9 commits into from
Oct 5, 2020
Merged

fix: flush wallet transactions #2918

merged 9 commits into from
Oct 5, 2020

Conversation

luciorubeens
Copy link
Contributor

@luciorubeens luciorubeens commented Oct 2, 2020

Summary

Flush transactions when changing the active wallet from the bottom sheet.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. Status: In Progress The issue or pull request is being worked on. labels Oct 2, 2020
@luciorubeens luciorubeens marked this pull request as ready for review October 3, 2020 13:35
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Oct 3, 2020
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #2918 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #2918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          349       349           
  Lines         4917      4925    +8     
  Branches       906       906           
=========================================
+ Hits          4917      4925    +8     
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/hooks/use-synchronizer.tsx 100.00% <100.00%> (ø)
...mains/wallet/pages/WalletDetails/WalletDetails.tsx 100.00% <100.00%> (ø)
...es/WalletDetails/hooks/use-wallet-transactions.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9878b88...6bb11b6. Read the comment docs.

@faustbrian faustbrian merged commit d6055b5 into develop Oct 5, 2020
@ghost ghost deleted the fix/flush-transactions branch October 5, 2020 05:21
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants