Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: adjustments to entity / delegate resignation #2921

Merged
merged 13 commits into from
Oct 4, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Oct 3, 2020

Summary

https://app.clickup.com/t/8mxkqz / https://app.clickup.com/t/8pqwwb and misc UI fixes.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Oct 3, 2020
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Oct 3, 2020
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Oct 3, 2020
@dated dated marked this pull request as ready for review October 4, 2020 00:26
@dated dated requested a review from faustbrian as a code owner October 4, 2020 00:26
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Oct 4, 2020
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #2921 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #2921   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          349       349           
  Lines         4922      4917    -5     
  Branches       906       906           
=========================================
- Hits          4922      4917    -5     
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/domains/profile/i18n.ts 100.00% <ø> (ø)
...rations/components/DelegateTable/DelegateTable.tsx 100.00% <ø> (ø)
src/domains/transaction/i18n.ts 100.00% <ø> (ø)
src/domains/transaction/routing.ts 100.00% <ø> (ø)
.../profile/pages/MyRegistrations/MyRegistrations.tsx 100.00% <100.00%> (ø)
...tions/components/DelegateTable/DelegateRowItem.tsx 100.00% <100.00%> (ø)
...ions/components/EntityTable/EntityTableRowItem.tsx 100.00% <100.00%> (ø)
...on/components/DelegateResignationForm/FormStep.tsx 100.00% <100.00%> (ø)
.../components/DelegateResignationForm/ReviewStep.tsx 100.00% <100.00%> (ø)
...components/DelegateResignationForm/SummaryStep.tsx 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea3886...2aa7dbe. Read the comment docs.

@faustbrian faustbrian merged commit 9878b88 into develop Oct 4, 2020
@ghost ghost deleted the refactor/resig-CU-8mxkqz branch October 4, 2020 02:28
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants