Skip to content

feat: 2.6 api endpoints #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 28, 2019
Merged

feat: 2.6 api endpoints #75

merged 7 commits into from
Oct 28, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Oct 18, 2019

Summary

Adds the following API endpoints

GET

  • bridgechains
  • bridgechains/{id}
  • businesses
  • businesses/{id}
  • businesses/{id}/bridgechains
  • wallets/{id}/locks
  • locks
  • locks/{id}

POST

  • businesses/search
  • bridgechains/search
  • locks/search
  • locks/unlocked

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Oct 18, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Oct 18, 2019
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #75 into master will increase coverage by 1.7%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #75     +/-   ##
===========================================
+ Coverage     88.59%   90.29%   +1.7%     
- Complexity       52       62     +10     
===========================================
  Files            11       13      +2     
  Lines           114      134     +20     
===========================================
+ Hits            101      121     +20     
  Misses           13       13
Impacted Files Coverage Δ Complexity Δ
src/API/Bridgechains.php 100% <100%> (ø) 3 <3> (?)
src/API/Businesses.php 100% <100%> (ø) 4 <4> (?)
src/API/Wallets.php 100% <100%> (ø) 9 <1> (+1) ⬆️
src/API/Locks.php 100% <100%> (ø) 4 <4> (?)
src/API/Transactions.php 100% <0%> (ø) 7% <0%> (-1%) ⬇️
src/API/Rounds.php

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae7b10...6ce1842. Read the comment docs.

@ghost
Copy link

ghost commented Oct 28, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Oct 28, 2019
@faustbrian faustbrian merged commit 77e891f into ArkEcosystem:master Oct 28, 2019
@ghost
Copy link

ghost commented Oct 28, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@dated dated deleted the feat/2.6-endpoints branch October 28, 2019 06:32
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: High More than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants