Skip to content

Conversation

@ryley-o
Copy link
Contributor

@ryley-o ryley-o commented Feb 11, 2023

Description of the change

Refactor and update style guidelines to reflect preference to not use Solidity modifiers.

This partially completes #483


@ryley-o ryley-o self-assigned this Feb 11, 2023
@ryley-o ryley-o marked this pull request as ready for review February 11, 2023 00:02
@ryley-o ryley-o requested a review from a team as a code owner February 11, 2023 00:02
Copy link
Contributor

@jakerockland jakerockland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic – thank you @ryley-o

One note, lets wait to fully close #483 until we've also done the cleanup of usage of existing modifiers (can also split the issue into two if you'd prefer).

@ryley-o ryley-o enabled auto-merge February 11, 2023 00:14
@ryley-o ryley-o merged commit 342e0d6 into main Feb 11, 2023
@ryley-o ryley-o deleted the ro/483 branch February 11, 2023 00:17
@ryley-o
Copy link
Contributor Author

ryley-o commented Feb 11, 2023

sounds good - the remaining work of removing modifiers from all active contracts has been tagged as a polish week task 🙏 thanks for calling that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants