Skip to content

Implementing Hideo's feedback #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2023
Merged

Implementing Hideo's feedback #11

merged 1 commit into from
Mar 24, 2023

Conversation

@grantoesterling
Copy link
Contributor

@grantoesterling grantoesterling commented Mar 24, 2023 •
edited
Loading

At long last, tackling a mainstay of our backlog: implementing Hideo's feedback

  • Adding package.lock (and removing from .gitignore)
  • Adding back project status badges (only for paused/live/upcoming) on project list page
  • Adding better messaging for minting

I was not able to test minting so not sure if they will work properly - but I pulled examples directly from wagmi's documentation so I imagine the surely will

Screenshot 2023-03-24 at 3 24 50 PM

Polish week, baby 😎

@grantoesterling grantoesterling requested review from a team, Asupkay, Jbern16 and asaltste March 24, 2023 20:53
@grantoesterling grantoesterling merged commit 5e8c489 into main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asaltste asaltste Awaiting requested review from asaltste

@Jbern16 Jbern16 Awaiting requested review from Jbern16

1 more reviewer

@Asupkay Asupkay Asupkay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grantoesterling @Asupkay