Skip to content

Conversation

@matthewjacobson
Copy link
Contributor

Migrating to WalletConnect v2 as described here

Side note: in testing I found that the mainnet subgraph at https://api.thegraph.com/subgraphs/name/artblocks/art-blocks is causing some errors. Specifically projectMinterConfiguration doesn't have the expected fields 'startPrice', 'startTime', and 'endTime'. This is causing Apollo to throw the following error from useProjects on the projects page:

ApolloError: Type ProjectMinterConfiguration has no field startPrice
Type ProjectMinterConfiguration has no field startTime
Type ProjectMinterConfiguration has no field endTime

@matthewjacobson matthewjacobson requested review from a team and Jbern16 June 21, 2023 01:24
@vercel
Copy link

vercel bot commented Jun 21, 2023

@matthewjacobson is attempting to deploy a commit to the Art Blocks Team on Vercel.

A member of the Team first needs to authorize it.

@matthewjacobson
Copy link
Contributor Author

Hey @jakerockland - any update on this? This subgraph issue is preventing mainnet deployment

@jakerockland
Copy link
Contributor

Hey @matthewjacobson thank you for the additional direct ping – I had missed the initial message here.

Specifically projectMinterConfiguration doesn't have the expected fields 'startPrice', 'startTime', and 'endTime'.

For Engine projects, we don't index these fields currently – which will be fixed after we have completed a large ongoing area of work around rearchitecting our minter suite, but currently Engine implementations need to pull these fields directly from a web3 RPC provider like Infura with the addresses being queried against being their individual partner-specific minter suite deployment.

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
artblocks-engine-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 0:10am

@jakerockland
Copy link
Contributor

PR approved – deployment running.

@jakerockland
Copy link
Contributor

@matthewjacobson have you validated these changes locally? If so, I think we're g2g on merging this and cutting a new minor version.

@matthewjacobson
Copy link
Contributor Author

@jakerockland yes changes have been verified locally - you will need to add a new environment variable to your deployment. I updated the readme and the sample .env file to show what's needed.

@jakerockland
Copy link
Contributor

@jakerockland yes changes have been verified locally - you will need to add a new environment variable to your deployment. I updated the readme and the sample .env file to show what's needed.

Fantastic – thank you @matthewjacobson 🙏

@jakerockland jakerockland merged commit a787769 into ArtBlocks:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants