Skip to content

Conversation

@rubentd
Copy link
Contributor

@rubentd rubentd commented Nov 27, 2022

Generate random tokenId and hash and preview a generator iframe
Fix dependency issues

Generate random tokenId and hash and preview a generator iframe
Fix dependency issues
@rubentd rubentd requested review from a team and Asupkay November 27, 2022 14:25
@Jbern16
Copy link
Contributor

Jbern16 commented Nov 28, 2022

@rubentd this is awesome! Would you mind including a screen capture of this working when you get a chance?

@Jbern16 Jbern16 closed this Nov 28, 2022
@Jbern16 Jbern16 reopened this Nov 28, 2022
@Jbern16
Copy link
Contributor

Jbern16 commented Nov 28, 2022

also adding @lyaunzbe as a reviewer to take a look at the generator usage here

@Jbern16 Jbern16 requested a review from lyaunzbe November 28, 2022 16:07
@rubentd
Copy link
Contributor Author

rubentd commented Nov 28, 2022

@rubentd this is awesome! Would you mind including a screen capture of this working when you get a chance?

Yes, no problem @Jbern16

Screen Shot 2022-11-28 at 1 13 13 PM

There's also a demo: http://pbab-demo.s3-website-us-east-1.amazonaws.com/

@jakerockland
Copy link
Contributor

TYVM for additional review here @Asupkay

Merging given 2-reviews, but if there is additional post-merge feedback from your end @lyaunzbe we can always add additional iteration.

@jakerockland jakerockland merged commit 5754198 into ArtBlocks:main Jan 25, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 25, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Art Blocks Contributor:

GitPOAP: 2023 Art Blocks Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@lyaunzbe
Copy link

Somehow missed the initial tag on this, apologies!

Just reviewed and all looks good from generator utilization side 🙌

@jakerockland
Copy link
Contributor

No sweat ser, thank you for TAL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants