Add condition to skip retrieving models that are not cascadable #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves the handling of
CascadeQueryListenerin scenarios where the model is not cascadable or lacks a primary key. Currently, sinceCascadeQueryListeneris hooked to theQueryExecutedevent, it triggers an unnecessary retrieve operation even for models that are not meant to be cascaded or have a null primary key.In cases such as mass deletion processes, this adds an extra query and processing time, slowing down performance. This PR introduces a condition to check
if (!$this->hasCascadingRelations($builder->getModel()) or $keyName === null), preventing the redundant retrieve event, thus optimizing the cascade process and reducing unnecessary overhead.Key changes: