feat(examples/n-body) Fix and improve the Rust example #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch first updates the documentation to compile the Rust example. Then this patch updates the Rust code, since `panic_implementation` is a deprecated feature. Also `extern` is similar to `extern "C"`. Less code is always better. Finally, this patch compiles and optimises the Rust Wasm binary file (with a simple `wasm-gc` run). The final binary size is 1.4Kb.
MaxGraey
reviewed
Mar 5, 2019
| @@ -9,4 +9,4 @@ crate-type = ["cdylib"] | |||
|
|
|||
| [profile.release] | |||
| lto = true | |||
| opt-level = 3 | |||
There was a problem hiding this comment.
It should stay '3' instead 's' because AS also using -O3 so for better comparison they should have same opt levels
MaxGraey
reviewed
Mar 5, 2019
| @@ -42,6 +42,6 @@ Benchmark | |||
| | **AssemblyScript WASM** | **2901** | **2** | | |||
| | AssemblyScript ASMJS | 3720 | 19* | | |||
| | JavaScript | 2716 | 5* | | |||
| | Rust WASM | 2883 | 13 | | |||
| | Rust WASM | 2883 | 1.4* | | |||
There was a problem hiding this comment.
Rust doesn't produce js glue code in current case so mark "*" is unnecessary
MaxGraey
reviewed
Mar 5, 2019
| @@ -1,7 +1,7 @@ | |||
| ### Build | |||
|
|
|||
| ```bash | |||
| cargo build --release --target=wasm32-unknown-unknown | |||
| cargo +nightly build --release --target wasm32-unknown-unknown | |||
There was a problem hiding this comment.
That's nice. I'm using nightly by default and totally forgot that others use stable or beta by default.
|
Thanks! Close to favour #528 |
|
Why closing the PR? I would have appreciated to update the PR myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch first updates the documentation to compile the Rust example.
Then this patch updates the Rust code, since
panic_implementationisa deprecated feature. Also
externis similar toextern "C". Lesscode is always better.
Finally, this patch compiles and optimises the Rust Wasm binary file
(with a simple
wasm-gcrun). The final binary size is 1.4Kb.I let you run the benchmark if necessary. I don't have the same setup so results will be too different.