Skip to content

Update nbody example for Rust #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2019
Merged

Update nbody example for Rust #528

merged 4 commits into from
Mar 6, 2019

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Mar 5, 2019

Relate to #527

@MaxGraey MaxGraey mentioned this pull request Mar 5, 2019
Closed
dcodeIO
dcodeIO reviewed Mar 5, 2019
View reviewed changes
Hywan
Hywan reviewed Mar 5, 2019
View reviewed changes
examples/n-body/README.md
| **AssemblyScript WASM** | **2921** | **2** |
| AssemblyScript ASMJS | 3807 | 19* |
| JavaScript | 2757 | 5* |
| Rust WASM | 2866 | 20 / 2** |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 13Kb before running wasm-gc. And get 1.4Kb after wasm-gc. How did you get those numbers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You used s flag instead 3. I commented about this in prev PR. You could recheck size by yourself using latest nightly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main goal of this example is speed bench and size was measured as side effect, so both compilers using -O3 opt flags

Hywan
Hywan suggested changes Mar 5, 2019
View reviewed changes
Copy link

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbers in the result table aren't correct.

@MaxGraey
Copy link
Member Author

MaxGraey commented Mar 5, 2019

Numbers in the result table aren't correct.

Why? You got another values for sizes?

@Hywan
Copy link

Hywan commented Mar 5, 2019

With the optimisation level 3, I get the same numbers.

@MaxGraey
Copy link
Member Author

MaxGraey commented Mar 5, 2019 •
edited
Loading

Great! I opened new PR because I should update timings anyway (previous measured on my local machine) But I very appreciate of your efforts and improvements. Thanks!

@dcodeIO dcodeIO merged commit 5f54713 into AssemblyScript:master Mar 6, 2019
@MaxGraey MaxGraey deleted the improve-nbody-rust branch March 6, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

+1 more reviewer

@Hywan Hywan Hywan requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxGraey @Hywan @dcodeIO