Conversation
rosvik
force-pushed
the
rosvik/school-ticket
branch
from
440f478 to
251cd50
Compare
Member
Author
|
@mjenssen Should we rename Update: We decided to go for |
rosvik
requested review from
jorelosorio,
marius-at-atb,
reidzeibel and
strandlie
reidzeibel
approved these changes
Mar 18, 2025
Member
reidzeibel
left a comment
reidzeibel
left a comment
There was a problem hiding this comment.
Since we are generalizing student into traveler, should schoolName be changed to organizationName? 😆
Member
Author
|
@reidzeibel We have talked about it, but we assume organization data will be displayed differently to school name. For schools we show "Home -> {schoolName}", while for orgs it might might be "Payed for by {orgName}" or something like that. |
Member
|
Then it looks like everything is in order 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new fare contract fields introduced by the school ticket.
needed for https://github.com/AtB-AS/kundevendt/issues/20063