MOZ-2554: Merge fixes from mbed-os-6.13.0-jfd-fixes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae19071.
Made i2c read/write functions virtual so that they can be overridden.
isircu
changed the title
jeppefrandsen
approved these changes
Aug 31, 2021
jeppefrandsen
left a comment
jeppefrandsen
left a comment
There was a problem hiding this comment.
Awesome work @isircu 🍻. We can test the mozart-fep changes on New York and S58 before merging 👍🏻
hansbinderup
approved these changes
Sep 1, 2021
Collaborator
hansbinderup
left a comment
hansbinderup
left a comment
There was a problem hiding this comment.
Looks good! Hard to review low level stuff, but I guess that you've tested it properly. I'll run some tests on S58 when merged to the fep 👍
| * '0' - Successfully recovered | ||
| * 'I2C_ERROR_BUS_BUSY' - In case of failure | ||
| */ | ||
| int recover(void); |
Collaborator
There was a problem hiding this comment.
@mads-bn isn't this what we talked about? Making it virtual?
isircu
added a commit
that referenced
this pull request
Sep 2, 2021
* Changed to C++20 * applied patch from fep low power * Changed to C++20 * Updated compile options * Added more fixes * Added event queue changes * Changed to hard float and fixed sleep * Added werror * Corrected compile warnings/errors * Updated system clock settings * Reverted change * Downgraded STM32Cube to 1.23.0 * Corrected build issues * Corrected mimimal printf compile warning * Revert "Downgraded STM32Cube to 1.23.0" This reverts commit ae19071. * Corrected build issues * Added I2C slave changes * Updated from old branch * Corrected I2C slave command * Minor rename * Corrected name * Virtual i2c read write Made i2c read/write functions virtual so that they can be overridden. * Removed obsolete file * Corrected unused variable in mbed_board.c * Added maybe_unused to validate_errno_values * Fix build errors Co-authored-by: Jeppe Frandsen <jeppe@algrens.dk> Co-authored-by: Hans Binderup <hbinderup94@gmail.com> Co-authored-by: Michael Jakobsen Højgaard <mhd@bang-olufsen.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with the mbed-os-6.13.0-jfd-fixes to upgrade to upstream 6.13.0 version and apply all patches