Skip to content

[QA-1802] Fix add to playlist on web #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2024
Merged

[QA-1802] Fix add to playlist on web #10366

merged 3 commits into from
Nov 6, 2024

Conversation

@Kyle-Shanks
Copy link
Contributor

@Kyle-Shanks Kyle-Shanks commented Nov 6, 2024

Description

Two small issues causing this:

  • Table was calling sort when it did not need to
  • The initial sort order was not being updated when tracks were added to the playlist

How Has This Been Tested?

Manually Tested

@Kyle-Shanks Kyle-Shanks requested review from a team and sliptype November 6, 2024 19:41
@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 80d676f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra
Copy link
Collaborator

audius-infra commented Nov 6, 2024

Preview this change https://demo.audius.co/kj-Fix-add-to-playlist-on-web

dylanjeffers
dylanjeffers approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to figure this one out

@Kyle-Shanks Kyle-Shanks merged commit b6d4155 into main Nov 6, 2024
3 of 5 checks passed
@Kyle-Shanks Kyle-Shanks deleted the kj-Fix-add-to-playlist-on-web branch November 6, 2024 22:20
audius-infra pushed a commit that referenced this pull request Nov 12, 2024
Audius Client (Web and Mobile) v1.5.108
d641260 
[517d45d] [QA-1742][QA-1818] Fix UPC persisting and add ean-13 compatibility (#10422) Randy Schott
[bd8a723] Fix client release creation (#10424) Sebastian Klingler
[a30727b] Replace getRecentBlockhash with getLatestBlockhash (#10420) Marcus Pasell
[134f478] Use rf instead of ref for sign up (#10418) Raymond Jacobson
[dc35975] Fix mobile track edit (#10411) Raymond Jacobson
[5e3e216] [QA-1815] Render track actions for deleted tracks in tables (#10409) Kyle Shanks
[e7c6a80] Fix user state issues with signUp breaking follows (#10419) Randy Schott
[e04b249] Revert cocoaods back to 1.13 (#10416) Dylan Jeffers
[697f57d] Fix download file names for ddex (#10393) Raymond Jacobson
[6c30da0] [C-5379] Update lineup tile stats (#10391) Dylan Jeffers
[6fda635] [C-5335] Mobile follow button snappy (#10405) Reed
[c1d6293] Fix mobile Track/Collection skeleton margins (#10406) Reed
[353ba80] Fix mobile profile skeleton background color (#10407) Reed
[4135d0e] [PAY-3585] Prevent async account fetch from delaying left nav if account is cached (#10403) Randy Schott
[20e7fb3] [PAY-3574] Simplify chat unread count logic (#10396) Reed
[dc64fb8] [PAY-3592] Always mark chat as read (temp fix) (#10397) Reed
[4d6199c] [QA-1812] Update referred reward progress label (#10388) Kyle Shanks
[8e199ab] [QA-1811] Fix tier change notif capitalization (#10400) Kyle Shanks
[a9c8ea2] [QA-1790] Fix boolean logic error in profile page reducers (#10399) Kyle Shanks
[01e998e] [C-5371] Improve tile press responsiveness (#10394) Andrew Mendelsohn
[c6e5fd4] [C-5336] Load more items on mobile feed/trending (#10395) Andrew Mendelsohn
[afd617d] [C-5368] Default @Handles list for comments (#10390) JD Francis
[4b742b3] [QA-1813] Fix useTabs leave animation opacity (#10387) Kyle Shanks
[b5b4a93] [C-5278] Trimmed newlines on comments (#10386) JD Francis
[68e34cd] [C-5362] Comments button on now playing (#10370) JD Francis
[4d37dc3] [C-5356] Apply autocorrection to last word in comment/DM (#10382) Isaac Solo
[d2c047a] Fix profile screen content not rendering (#10384) Andrew Mendelsohn
[9dabd1b] [C-5364] Track and Collection Tile Stat updates (#10379) Dylan Jeffers
[45f2e3f] [QA-1753] Fix Suggested Artists Popup lag (#10380) Kyle Shanks
[3ada3d5] [PAY-3544] Fix flashing empty state on mobile chat screen (#10377) Reed
[98dfde5] ⚠️ [PAY-3570] Refactor track image to use artwork directly (#10316) Raymond Jacobson
[893172b] Add copius logs to change email flow (#10375) Marcus Pasell
[70ff58d] [C-5330] Snappy previewing artists in signup (#10372) Reed
[ff7b841] [C-5378] Fade in mobile screen content on load (#10369) Reed
[b6d4155] [QA-1802] Fix add to playlist on web (#10366) Kyle Shanks
[4f23426] [C-5363] Open comment drawer from feed (#10354) JD Francis
[eeb8067] [C-5377] Avoid selecting full account object (#10359) Andrew Mendelsohn
[f472509] fix mobile lint (#10367) Andrew Mendelsohn
[b4c4d71] [C-5333, C-5334] Fix animated button perf; fix useFeatureFlag perf (#10356) Andrew Mendelsohn
[24cd7b3] Fix mobile profile header sticky (#10363) Reed
[c134d1c] [PAY-3582][PAY-3583][PAY-3584] Fix bugbash comments for rights declaration  (#10353) Farid Salau
[39fb68b] [PAY-3580] Make user bank logic for first time buyers more robust (#10345) Randy Schott
[42152f5] Add undefined check for managers before mapping (#10360) Marcus Pasell
[3103a22] [C- 5357] Fix sign-up redirect (#10355) Dylan Jeffers
[ba20259] [PAY-3569] Get direct URLs to content node in API response (#10344) Marcus Pasell
[761ac5d] Fix sign up issue related to formik version issues (#10358) Dylan Jeffers
[db9c6af] [C-5320] Improve profile screen loading performance (#10349) Andrew Mendelsohn
[d3dccb7] [C-5375, C-5376] Improve chats & rewards screen loading perf (#10351) Andrew Mendelsohn
[4ee852d] Remove scheduled release timezone on access-type-labels (#10350) Dylan Jeffers
[7d6e3fc] [C-5372] Improve access type labels (#10342) Dylan Jeffers
[452241f] Fix null error (#10343) Farid Salau
[12175d1] [PAY-3578] Migrate sign-in out of AudiusBackend (#10311) Randy Schott
[33932b0] Update app icon names to ensure light mode first (#10340) Dylan Jeffers
[a67336f] Minor icon updates (#10337) Dylan Jeffers
[a6100b8] Fix FilterButtonOptionsList label prop (#10338) Sebastian Klingler
[8776a4a] [C-5220] Add comment reply animations on mobile (#10336) Kyle Shanks
[e4d6c52] Version Packages (#10334) github-actions[bot]
[c0ff8e6] Fix ios build (#10335) Dylan Jeffers
[fc961e1] Version Packages (#9970) github-actions[bot]
[e26907e] Update ios icons (#10330) Dylan Jeffers
[a2d51f8] [PAY-3559] Add direct publishing payments to Stems (#10320) Farid Salau
[7e5f8d4] [QA-1798] Close keyboard on submit for comments and DMs on mobile (#10328) Kyle Shanks
[2570338] [C-5348] Add premium-extras UI (#10274) Dylan Jeffers
[a5b0b61] Downgrade Xcode to latest 15x (#10326) Dylan Jeffers
[724a8e7] Fix ios and android builds (#10325) Dylan Jeffers
[4daf0e5] Fix android build (#10324) Dylan Jeffers
[10c3f38] [C-5367] Fix harmony-native button initial color (#10322) Dylan Jeffers
[3b06f4c] Upgrade ruby version to 3.3.5 (#10323) Dylan Jeffers
[1724064] Remove primary/secondary loading for feed screen (#10319) Dylan Jeffers
[39fe1d6] Upgrade mobile apps to 1.1.122 (#10317) Dylan Jeffers
[697d115] [DEVREL] - Max apps bumped to 5 (#10234) Sam Gutentag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffers dylanjeffers dylanjeffers approved these changes

@sliptype sliptype Awaiting requested review from sliptype

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kyle-Shanks @audius-infra @dylanjeffers