Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

Conversation

@Jamlee
Copy link
Contributor

@Jamlee Jamlee commented Oct 3, 2024

Summary

Under the current circumstances, Example cannot run because the files in AuroraEditorSourceEditor seem to have only been modified halfway, some are called AuroraEditorSourceEditorExample, and some are called CodeEditorSourceEditor. I changed the whole thing to AuroraEditorSourceEditorExample and it runs through on Xcode 15.

Changes Made

  1. The Example directory compiles through as a whole.
  2. The LanguagePicker in Example cannot echo back because CodeLanguage always defaults to false when compared.
  3. textViewDidChange must be public

TODO

none

Motivation

Run the Example normally to understand more intuitively the principle of implementing an editor with SwiftUI

Testing

none

Screenshots/GIFs

image

Checklist

Please ensure all of the following are completed before submitting the PR:

  • Code has been tested and verified.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully.
  • Code follows the project's coding guidelines and style.
  • The branch is up-to-date with the latest changes from the main branch.
  • Reviewed by at least one other contributor.

Related Issues

none

Additional Notes

none

Jamlee added 2 commits October 3, 2024 08:14
1. Example can not run by xcode.
2. language picker can not disply selected value.
when build package, textViewDidChange method occur error that is not public
@aurora-care-bear
Copy link

Thanks for submitting a pull request!
We will review it as soon as possible.

@Jamlee
Copy link
Contributor Author

Jamlee commented Oct 3, 2024

@nanashili hello, Would you please review the code? 😄

Copy link
Member

@nanashili nanashili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nanashili nanashili merged commit c67e564 into AuroraEditor:main Oct 3, 2024
@aurora-care-bear
Copy link

Hey @Jamlee,

Thanks for your contribution.
Your PR has been merged!
Your name will appear on https://auroraeditor.com/#contributors in a few moments, if you have contributed to the editor.

Thanks again for your contribution!

Kind Regards,
Aurora Editor Team.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants