fix chrome drive sync issues #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mymindstorm
commented
Dec 4, 2018
mymindstorm
commented
- Fixes issue with text not being substituted
- Fixes issue where failure message shows up instead of auth_revoke message
Sneezry
reviewed
Dec 8, 2018
Sneezry
reviewed
Dec 8, 2018
kandikane
approved these changes
Dec 14, 2018
Sneezry
reviewed
Dec 21, 2018
|
@Sneezry is this okay to merge? |
Sneezry
reviewed
Jan 17, 2019
| const res = JSON.parse(xhr.responseText); | ||
| if (res.error) { | ||
| if (res.error.code === 401) { | ||
| if (navigator.userAgent.indexOf('Chrome') !== -1) { |
There was a problem hiding this comment.
No. We have to handle Chrome Google account login differently (via chrome.identity) from Firefox because of Google API restrictions. chrome.identity isn't part of Firefox, hence the check here.
When a user revokes a token from Google's side the token is still cached in Chrome. So, if a user tries to sign in again directly after revoking a token chrome.identity.getAuthToken would notice a cached token is still available and pull it even though it was revoked. This causes the extension to show a 'Failure' message since the 'new' token is revoked already.
To reproduce with 5.2.2:
- login to google drive
- sync
- revoke access from https://myaccount.google.com/permissions
- keep syncing until the extension gets a 401
- close and open the extension popup (not chrome)
- try to login again
- get error
- goto 6
To prove it's the cache after reproducing:
- see error after trying to login
- open chrome://identity-internals/ and revoke token
- try to login to drive sync
- success
Sneezry
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.