Skip to content

fix security issue #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2019
Merged

fix security issue #275

merged 1 commit into from
Feb 16, 2019

Conversation

mymindstorm
Copy link
Member

fixes #272

@mymindstorm mymindstorm requested a review from Sneezry February 2, 2019 18:13
@Benno-K
Copy link

Benno-K commented Feb 10, 2019

@Sneezry @mymindstorm
Is there anything where I could help to make progress on this topic?
I do not want to put pressure on you, but on the other hand as long as the fix isn't published as - or along with - a new version, scanned secrets are quite likely to be stored unencrypted for a lot of users.
(Off course, I myself am already using the modified code, so my secrets are safe)

@mymindstorm mymindstorm merged commit 0b2fcd4 into dev Feb 16, 2019
@mymindstorm mymindstorm deleted the qr-password-fix branch February 16, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sneezry Sneezry Sneezry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Password-protected backups and stored settings may have unencrypted secrets

3 participants

@mymindstorm @Benno-K @Sneezry