Skip to content

Conversation

@Sneezry
Copy link
Member

@Sneezry Sneezry commented Jul 8, 2021

Snipaste_2021-07-08_14-55-49

@Sneezry Sneezry requested a review from mymindstorm July 8, 2021 07:04
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #698 (e79cca3) into dev (7eb3d20) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head e79cca3 differs from pull request most recent head 3701397. Consider uploading reports for the commit 3701397 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #698      +/-   ##
==========================================
+ Coverage   18.39%   18.49%   +0.10%     
==========================================
  Files          17       17              
  Lines        1544     1546       +2     
  Branches      335      335              
==========================================
+ Hits          284      286       +2     
  Misses       1227     1227              
  Partials       33       33              
Impacted Files Coverage Δ
src/store/Menu.ts 50.00% <100.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb3d20...3701397. Read the comment docs.

@Sneezry
Copy link
Member Author

Sneezry commented Jul 16, 2021

@mymindstorm any idea with the test failure? It seems the test engine failed to connect to the browser.

Co-authored-by: mymindstorm <mymindstorm@evermiss.net>
Copy link
Member

@mymindstorm mymindstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing worked perfectly. I think an example could be added in schema.json, just to clarify that no slashes are needed (e.g. /[A-Z]+/ should be [A-Z]+).

@Sneezry
Copy link
Member Author

Sneezry commented Aug 21, 2021

Testing worked perfectly. I think an example could be added in schema.json, just to clarify that no slashes are needed (e.g. /[A-Z]+/ should be [A-Z]+).

Updated.

@Sneezry Sneezry merged commit 37a8b1f into dev Aug 21, 2021
@Sneezry Sneezry deleted the password-policy branch August 21, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants