Skip to content

Conversation

@TheR1sing3un
Copy link
Contributor

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

1. add basic metadata type in Kafka on S3 architecture

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. support image::write function for Stream related images

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. fix compile errors

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. support Stream related delta function: replay

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. add test to verify the Stream related image and delta

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
@superhx
Copy link
Collaborator

superhx commented Aug 21, 2023

Comment to modified part in Kafka code.
ex.
// Kafka on S3 inject start
our code
// Kafka on S3 inject end

1. add S3ObjectControlManager to manage all S3Object's lifecycle

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
…t to 64bit

1. rename S3 related class name
2. change epoch from 32bit to 64bit

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. fix name changing related compile errors

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. add comment to identify Kafka on S3

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. rename streams with streamObjects

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
@TheR1sing3un TheR1sing3un marked this pull request as ready for review August 21, 2023 03:38
@TheR1sing3un TheR1sing3un requested a review from superhx August 21, 2023 03:38
@superhx superhx merged commit 6460420 into develop Aug 21, 2023
@superhx superhx deleted the support_metadata branch August 21, 2023 03:38
superhx pushed a commit that referenced this pull request Feb 28, 2024
This change introduces some basic clean up and refactoring for forthcoming commits related to the revised fetch code for the consumer threading refactor project.

Reviewers: Christo Lolov <lolovc@amazon.com>, Jun Rao <junrao@gmail.com>
daniel-y pushed a commit that referenced this pull request Mar 5, 2024
Support basic metadata management in Kafka on S3 architecture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants