Skip to content

chore(release): tag in the main branch manually rather than the PR branch #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2024
Merged

chore(release): tag in the main branch manually rather than the PR branch #1054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions automq_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,9 @@ def do_release(tag, s3stream_tag):
cmd("Committing changes", ["git", "commit", "--all", "--gpg-sign", "--signoff", "--message", f"ci: bump version to {tag}"])
cmd("Pushing changes", ["git", "push", "--quiet", "origin", new_branch])

cmd("Tagging %s" % tag, ["git", "tag", "--sign", "--annotate", tag, "--message", f"release {tag}"])
cmd("Pushing tag %s" % tag, ["git", "push", "--quiet", "origin", tag])
# TODO: tag it in the main branch rather than in the PR branch
# cmd("Tagging %s" % tag, ["git", "tag", "--sign", "--annotate", tag, "--message", f"release {tag}"])
# cmd("Pushing tag %s" % tag, ["git", "push", "--quiet", "origin", tag])

return new_branch

Expand Down Expand Up @@ -197,3 +198,8 @@ def check_before_started(tag, s3stream_tag):
print(f"=== release {tag} done ===")
print(f"Please create a PR to merge release branch to {main_branch} visiting:")
print(f" https://github.com/AutoMQ/automq-for-kafka/pull/new/{main_branch}...{branch}")
print(f"After the PR is merged, please tag it:")
print(f" git checkout {main_branch}")
print(f" git pull")
print(f" git tag --sign --annotate {tag} --message 'release {tag}'")
print(f" git push origin {tag}")