Skip to content

fix(auto_balancer): avoid action score calculation for unsupported goal #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024
Merged

fix(auto_balancer): avoid action score calculation for unsupported goal #1305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/java/kafka/autobalancer/goals/AbstractGoal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,12 @@ public double actionAcceptanceScore(Action action, ClusterModelSnapshot cluster)
}
BrokerUpdater.Broker srcBrokerBefore = cluster.broker(action.getSrcBrokerId());
BrokerUpdater.Broker destBrokerBefore = cluster.broker(action.getDestBrokerId());

if (!srcBrokerBefore.getMetricVersion().isGoalSupported(this)
|| !destBrokerBefore.getMetricVersion().isGoalSupported(this)) {
return POSITIVE_ACTION_SCORE_THRESHOLD;
}

BrokerUpdater.Broker srcBrokerAfter = srcBrokerBefore.copy();
BrokerUpdater.Broker destBrokerAfter = destBrokerBefore.copy();

Expand Down