feat(s3): support basic create/open stream proceessing in controller #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheR1sing3un
commented
Aug 23, 2023
TheR1sing3un
commented
- support basic create/open stream proceessing in controller
- fix some code to pass checkstyle and spot-bugs
… operation 1. support S3StreamControlManager handles stream's create/open operation Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. add S3StreamControlManager basic create/open stream test 2. fix to pass checkstyle and spot bugs checking Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
superhx
reviewed
Aug 23, 2023
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
Outdated
Show resolved
Hide resolved
metadata/src/main/java/org/apache/kafka/controller/stream/StreamControlManager.java
Show resolved
Hide resolved
metadata/src/main/java/org/apache/kafka/controller/stream/StreamControlManager.java
Show resolved
Hide resolved
metadata/src/main/java/org/apache/kafka/controller/stream/StreamControlManager.java
Outdated
Show resolved
Hide resolved
metadata/src/main/java/org/apache/kafka/controller/stream/StreamControlManager.java
Outdated
Show resolved
Hide resolved
metadata/src/main/java/org/apache/kafka/controller/stream/StreamControlManager.java
Outdated
Show resolved
Hide resolved
…y future 1. increase S3 related Errors code to avoid incompatibility future Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. make range's endOffset exclusive Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
1. add some TODO tasks in comments Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
superhx
approved these changes
Aug 23, 2023
daniel-y
pushed a commit
that referenced
this pull request
Mar 5, 2024
feat(s3): support basic create/open stream proceessing in controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.