fix(s3stream): use segment-unique id as file cache key #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the position used in file cache is relative to the start offset of a segment in the underlying stream, so different segment from same partition should not share the same block map in order to avoid position conflict Signed-off-by: Shichao Nie <niesc@automq.com>
SCNieh
requested review from
Chillax-0v0,
ShadowySpirits and
superhx
as code owners
superhx
previously approved these changes
Jul 4, 2024
ShadowySpirits
previously approved these changes
Jul 4, 2024
Chillax-0v0
previously approved these changes
Jul 4, 2024
Signed-off-by: Shichao Nie <niesc@automq.com>
SCNieh
dismissed stale reviews from Chillax-0v0, ShadowySpirits, and superhx
via
ea242a4
superhx
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the position used in file cache is relative to the start offset of a segment in the underlying stream, so different segment from same partition should not share the same block map in order to avoid position conflict