fix(stream): release FetchResults if the subsequent fetch fails
#2172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ning Yu <ningyu@automq.com>
Chillax-0v0
requested review from
Gezi-lzq,
SCNieh and
superhx
as code owners
…fails" This reverts commit 5836a6a.
… reverse order Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
superhx
approved these changes
Nov 22, 2024
Chillax-0v0
added a commit
that referenced
this pull request
Nov 22, 2024
) * fix(stream): release `FetchResult`s if the subsequent fetch fails Signed-off-by: Ning Yu <ningyu@automq.com> * revert: "fix(stream): release `FetchResult`s if the subsequent fetch fails" This reverts commit 5836a6a. * refactor: add the `FetchResult` into the list in order rather than in reverse order Signed-off-by: Ning Yu <ningyu@automq.com> * fix: release `FetchResult`s if failed to fetch Signed-off-by: Ning Yu <ningyu@automq.com> --------- Signed-off-by: Ning Yu <ningyu@automq.com>
Chillax-0v0
added a commit
that referenced
this pull request
Nov 22, 2024
) * fix(stream): release `FetchResult`s if the subsequent fetch fails Signed-off-by: Ning Yu <ningyu@automq.com> * revert: "fix(stream): release `FetchResult`s if the subsequent fetch fails" This reverts commit 5836a6a. * refactor: add the `FetchResult` into the list in order rather than in reverse order Signed-off-by: Ning Yu <ningyu@automq.com> * fix: release `FetchResult`s if failed to fetch Signed-off-by: Ning Yu <ningyu@automq.com> --------- Signed-off-by: Ning Yu <ningyu@automq.com>
Chillax-0v0
added a commit
that referenced
this pull request
Nov 22, 2024
) * fix(stream): release `FetchResult`s if the subsequent fetch fails Signed-off-by: Ning Yu <ningyu@automq.com> * revert: "fix(stream): release `FetchResult`s if the subsequent fetch fails" This reverts commit 5836a6a. * refactor: add the `FetchResult` into the list in order rather than in reverse order Signed-off-by: Ning Yu <ningyu@automq.com> * fix: release `FetchResult`s if failed to fetch Signed-off-by: Ning Yu <ningyu@automq.com> --------- Signed-off-by: Ning Yu <ningyu@automq.com>
This was referenced Nov 22, 2024
superhx
pushed a commit
that referenced
this pull request
Nov 22, 2024
) fix(stream): release `FetchResult`s if the subsequent fetch fails (#2172) * fix(stream): release `FetchResult`s if the subsequent fetch fails * revert: "fix(stream): release `FetchResult`s if the subsequent fetch fails" This reverts commit 5836a6a. * refactor: add the `FetchResult` into the list in order rather than in reverse order * fix: release `FetchResult`s if failed to fetch --------- Signed-off-by: Ning Yu <ningyu@automq.com>
superhx
pushed a commit
that referenced
this pull request
Nov 22, 2024
) fix(stream): release `FetchResult`s if the subsequent fetch fails (#2172) * fix(stream): release `FetchResult`s if the subsequent fetch fails * revert: "fix(stream): release `FetchResult`s if the subsequent fetch fails" This reverts commit 5836a6a. * refactor: add the `FetchResult` into the list in order rather than in reverse order * fix: release `FetchResult`s if failed to fetch --------- Signed-off-by: Ning Yu <ningyu@automq.com>
superhx
pushed a commit
that referenced
this pull request
Nov 25, 2024
) fix(stream): release `FetchResult`s if the subsequent fetch fails (#2172) * fix(stream): release `FetchResult`s if the subsequent fetch fails * revert: "fix(stream): release `FetchResult`s if the subsequent fetch fails" This reverts commit 5836a6a. * refactor: add the `FetchResult` into the list in order rather than in reverse order * fix: release `FetchResult`s if failed to fetch --------- Signed-off-by: Ning Yu <ningyu@automq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2171