perf(s3stream): parallel append & optimize logcache init #2994
+42
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superhx
requested review from
1sonofqiu,
Gezi-lzq and
woshigaopp
as code owners
Gezi-lzq
previously approved these changes
Nov 10, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces optimizations for the LogCache system and parallelizes append callbacks in S3Storage. The key changes include using adaptive initial capacity for internal ArrayList allocations based on previous block sizes, and distributing append callbacks across multiple event loops for better concurrency.
- Added capacity hints to StreamCache initialization to reduce ArrayList resizing overhead
- Introduced parallel execution of append callbacks using stream-based EventLoop executors
- EventLoop threads are allocated based on CPU core count
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| LogCache.java | Added Function parameter for capacity hints and new StreamCache constructor with initial capacity to optimize ArrayList allocation |
| S3Storage.java | Introduced EventLoop array for parallel append callback execution and refactored handleAppendCallback to distribute work across executors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
s3stream/src/main/java/com/automq/stream/s3/cache/LogCache.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Robin Han <hanxvdovehx@gmail.com>
superhx
force-pushed
the
perf_parallel_append
branch
from
77cf319 to
b2afe1b
Compare
Gezi-lzq
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.