Skip to content

fix(logcache): guard cache free with writeLock #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

fix(logcache): guard cache free with writeLock #3022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions s3stream/src/main/java/com/automq/stream/s3/cache/LogCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,13 +380,13 @@ public long capacity() {
}

public void clearStreamRecords(long streamId) {
readLock.lock();
writeLock.lock();
try {
for (LogCacheBlock block : blocks) {
block.free(streamId);
}
} finally {
readLock.unlock();
writeLock.unlock();
}
}

Expand Down Expand Up @@ -519,12 +519,10 @@ public void free() {
}

public void free(long streamId) {
suppress(() -> {
StreamCache streamCache = map.remove(streamId);
if (streamCache != null) {
streamCache.free();
}
}, LOGGER);
StreamCache streamCache = map.remove(streamId);
if (streamCache != null) {
LOG_CACHE_ASYNC_EXECUTOR.execute(() -> suppress(streamCache::free, LOGGER));
}
}

public void addFreeListener(FreeListener freeListener) {
Expand Down
Loading