Skip to content

fix(e2e): unify jackson to 2.16.0 #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2023
Merged

fix(e2e): unify jackson to 2.16.0 #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8d1c8f
fix(e2e): unite jackson dependency to 2.16.0
superhx Nov 26, 2023
cf9825a
fix: deprecated API
superhx Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public class JsonConverter implements Converter, HeaderConverter {
// names specified in the field
private static final HashMap<String, LogicalTypeConverter> LOGICAL_CONVERTERS = new HashMap<>();

private static final JsonNodeFactory JSON_NODE_FACTORY = JsonNodeFactory.withExactBigDecimals(true);
private static final JsonNodeFactory JSON_NODE_FACTORY = new JsonNodeFactory(true);

static {
LOGICAL_CONVERTERS.put(Decimal.LOGICAL_NAME, new LogicalTypeConverter() {
Expand Down
2 changes: 1 addition & 1 deletion connect/json/src/main/java/org/apache/kafka/connect/json/JsonDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class JsonDeserializer implements Deserializer<JsonNode> {
* Default constructor needed by Kafka
*/
public JsonDeserializer() {
this(Collections.emptySet(), JsonNodeFactory.withExactBigDecimals(true));
this(Collections.emptySet(), new JsonNodeFactory(true));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion connect/json/src/main/java/org/apache/kafka/connect/json/JsonSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class JsonSerializer implements Serializer<JsonNode> {
* Default constructor needed by Kafka
*/
public JsonSerializer() {
this(Collections.emptySet(), JsonNodeFactory.withExactBigDecimals(true));
this(Collections.emptySet(), new JsonNodeFactory(true));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion connect/json/src/test/java/org/apache/kafka/connect/json/JsonConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public class JsonConverterTest {

private final ObjectMapper objectMapper = new ObjectMapper()
.enable(DeserializationFeature.USE_BIG_DECIMAL_FOR_FLOATS)
.setNodeFactory(JsonNodeFactory.withExactBigDecimals(true));
.setNodeFactory(new JsonNodeFactory(true));

private final JsonConverter converter = new JsonConverter();

Expand Down
6 changes: 3 additions & 3 deletions gradle/dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ versions += [
grgit: "4.1.1",
httpclient: "4.5.13",
easymock: "4.3",
jackson: "2.13.4",
jacksonDatabind: "2.13.4.2",
jackson: "2.16.0",
jacksonDatabind: "2.16.0",
jacoco: "0.8.7",
javassist: "3.27.0-GA",
jetty: "9.4.48.v20220622",
Expand Down Expand Up @@ -128,7 +128,7 @@ versions += [
zookeeper: "3.6.3",
zstd: "1.5.2-1",
commonLang: "3.12.0",
s3stream: "0.5.5-SNAPSHOT",
s3stream: "0.5.6-SNAPSHOT",
]
libs += [
activation: "javax.activation:activation:$versions.activation",
Expand Down