Skip to content

feat: partition check closed before lock #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023
Merged

feat: partition check closed before lock #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions core/src/main/scala/kafka/cluster/Partition.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,13 @@ class Partition(val topicPartition: TopicPartition,
}

// AutoMQ for Kafka inject start
private def checkClosed(): Unit = {
if (closed) {
throw new NotLeaderOrFollowerException("Leader %d for partition %s on broker %d is already closed"
.format(localBrokerId, topicPartition, localBrokerId))
}
}

/**
* Close this partition and trigger a re-election.
* It may be messy here, but it is necessary to ensure the following steps:
Expand Down Expand Up @@ -1268,12 +1275,10 @@ class Partition(val topicPartition: TopicPartition,

def appendRecordsToLeader(records: MemoryRecords, origin: AppendOrigin, requiredAcks: Int,
requestLocal: RequestLocal): LogAppendInfo = {
checkClosed()
val (info, leaderHWIncremented) = inReadLock(leaderIsrUpdateLock) {
// AutoMQ for Kafka inject start
if (closed) {
throw new NotLeaderOrFollowerException("Leader %d for partition %s on broker %d is already closed"
.format(localBrokerId, topicPartition, localBrokerId))
}
checkClosed()
// AutoMQ for Kafka inject end
leaderLogIfLocal match {
case Some(leaderLog) =>
Expand Down Expand Up @@ -1372,7 +1377,9 @@ class Partition(val topicPartition: TopicPartition,

logReadInfo
} else {
checkClosed()
inReadLock(leaderIsrUpdateLock) {
checkClosed()
val localLog = localLogWithEpochOrThrow(
fetchPartitionData.currentLeaderEpoch,
fetchParams.fetchOnlyLeader
Expand Down