Skip to content

fix: don't deprecate s3.wal.path, plus a minor polish of s3url #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix: don't deprecate s3.wal.path, plus a minor polish of s3url #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/kraft/broker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ s3.bucket=ko3
#s3.path.style=true

# The file path of delta WAL in block device
# DEPRECATED TIPS: This property will be replaced by S3Url later in the future version. Reference the official document and use S3Url to start AutoMQ is recommended.
s3.wal.path=/tmp/kraft-broker-logs/s3wal

# The maximum size of delta WAL in block device, default 2GB
Expand Down
1 change: 0 additions & 1 deletion config/kraft/server.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ s3.bucket=ko3
#s3.path.style=true

# The file path of delta WAL in block device
# DEPRECATED TIPS: This property will be replaced by S3Url later in the future version. Reference the official document and use S3Url to start AutoMQ is recommended.
s3.wal.path=/tmp/kraft-combined-logs/s3wal

# The maximum size of delta WAL in block device, default 2GB
Expand Down
2 changes: 1 addition & 1 deletion kshell-sdk/src/main/java/com/automq/s3shell/sdk/model/S3Url.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public static S3Url parse(String s3Url) throws IllegalArgumentException {
clusterId = value;
break;
case "s3-path-style":
s3PathStyle = Boolean.valueOf(value);
s3PathStyle = Boolean.parseBoolean(value);
break;
default:
throw new IllegalArgumentException("Unknown parameter: " + key);
Expand Down