Skip to content

feat(metrics): change ot cardinality limit from 2000 -> 5000 #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2024
Merged

feat(metrics): change ot cardinality limit from 2000 -> 5000 #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b30cb6
feat(metrics): change ot cardinality limit from 2000 -> 10000
SCNieh Feb 4, 2024
45718db
style(metrics): remove unused imports
SCNieh Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/scala/kafka/log/stream/s3/telemetry/TelemetryConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
import io.opentelemetry.api.common.AttributeKey;

public class TelemetryConstants {
// The maximum number of combinations of attributes for a single metric
public static final int CARDINALITY_LIMIT = 10000;
public static final String COMMON_JMX_YAML_CONFIG_PATH = "/jmx/rules/common.yaml";
public static final String BROKER_JMX_YAML_CONFIG_PATH = "/jmx/rules/broker.yaml";
public static final String CONTROLLER_JMX_YAML_CONFIG_PATH = "/jmx/rules/controller.yaml";
Expand Down
10 changes: 7 additions & 3 deletions core/src/main/scala/kafka/log/stream/s3/telemetry/TelemetryManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import io.opentelemetry.sdk.metrics.export.MetricReader;
import io.opentelemetry.sdk.metrics.export.PeriodicMetricReader;
import io.opentelemetry.sdk.metrics.export.PeriodicMetricReaderBuilder;
import io.opentelemetry.sdk.metrics.internal.SdkMeterProviderUtil;
import io.opentelemetry.sdk.resources.Resource;
import io.opentelemetry.sdk.trace.SdkTracerProvider;
import io.opentelemetry.sdk.trace.SpanProcessor;
Expand Down Expand Up @@ -289,7 +290,8 @@ private void initOTLPExporter(SdkMeterProviderBuilder sdkMeterProviderBuilder, K

MetricReader periodicReader = builder.setInterval(Duration.ofMillis(kafkaConfig.s3ExporterReportIntervalMs())).build();
metricReaderList.add(periodicReader);
sdkMeterProviderBuilder.registerMetricReader(periodicReader);
SdkMeterProviderUtil.registerMetricReaderWithCardinalitySelector(sdkMeterProviderBuilder, periodicReader,
instrumentType -> TelemetryConstants.CARDINALITY_LIMIT);
LOGGER.info("OTLP exporter registered, endpoint: {}, protocol: {}", otlpExporterHost, protocol);
}

Expand All @@ -302,7 +304,8 @@ private void initLogExporter(SdkMeterProviderBuilder sdkMeterProviderBuilder, Ka
metricReaderList.add(periodicReader);
metricsLogger = java.util.logging.Logger.getLogger(LoggingMetricExporter.class.getName());
metricsLogger.setLevel(Level.FINEST);
sdkMeterProviderBuilder.registerMetricReader(periodicReader);
SdkMeterProviderUtil.registerMetricReaderWithCardinalitySelector(sdkMeterProviderBuilder, periodicReader,
instrumentType -> TelemetryConstants.CARDINALITY_LIMIT);
LOGGER.info("Log exporter registered");
}

Expand All @@ -317,7 +320,8 @@ private void initPrometheusExporter(SdkMeterProviderBuilder sdkMeterProviderBuil
.setHost(promExporterHost)
.setPort(promExporterPort)
.build();
sdkMeterProviderBuilder.registerMetricReader(prometheusHttpServer);
SdkMeterProviderUtil.registerMetricReaderWithCardinalitySelector(sdkMeterProviderBuilder, prometheusHttpServer,
instrumentType -> TelemetryConstants.CARDINALITY_LIMIT);
LOGGER.info("Prometheus exporter registered, host: {}, port: {}", promExporterHost, promExporterPort);
}

Expand Down