Skip to content

fix(telemetry): fix OTel collector http endpoint #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix(telemetry): fix OTel collector http endpoint #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions core/src/main/scala/kafka/log/stream/s3/telemetry/TelemetryManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,6 @@ private Optional<String> getOTLPEndpoint(String endpoint) {
if (StringUtils.isBlank(endpoint)) {
return Optional.empty();
}
if (!endpoint.startsWith("http://")) {
endpoint = "https://" + endpoint;
}
return Optional.of(endpoint);
}

Expand Down
4 changes: 2 additions & 2 deletions docker/telemetry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ due to performance and security concerns.

# Sample OTLP endpoints
# OTel Collector (gRPC): http://${endpoint}:4317
# OTel Collector (HTTP): http://${endpoint}:4318
# Prometheus OTLP receiver: http://${endpoint}:9090/api/v1/otlp/v1/metrics
# OTel Collector (HTTP): http://${endpoint}:4318/v1/metrics
# Prometheus (OpenSource) OTLP receiver: http://${endpoint}:9090/api/v1/otlp/v1/metrics

# Metrics report interval
s3.telemetry.exporter.report.interval.ms=5000
Expand Down