Skip to content

feat: add object ttl reach log #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

feat: add object ttl reach log #825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion metadata/src/main/java/org/apache/kafka/controller/stream/S3ObjectControlManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.OptionalLong;
Expand Down Expand Up @@ -180,7 +181,7 @@ public ControllerResult<Errors> commitObject(long objectId, long objectSize, lon
}
S3Object object = this.objectsMetadata.get(objectId);
if (object == null) {
log.error("object {} not exist when commit stream set object", objectId);
log.error("object {} not exist when commit object", objectId);
return ControllerResult.of(Collections.emptyList(), Errors.OBJECT_NOT_EXIST);
}
// verify the state
Expand Down Expand Up @@ -263,6 +264,7 @@ public void replay(RemoveS3ObjectRecord record) {
*/
public ControllerResult<Void> checkS3ObjectsLifecycle() {
List<ApiMessageAndVersion> records = new ArrayList<>();
List<Long> ttlReachedObjects = new LinkedList<>();
// check the expired objects
this.preparedObjects.stream().
map(objectsMetadata::get).
Expand All @@ -276,6 +278,7 @@ public ControllerResult<Void> checkS3ObjectsLifecycle() {
.setExpiredTimeInMs(obj.getExpiredTimeInMs())
.setCommittedTimeInMs(obj.getCommittedTimeInMs())
.setMarkDestroyedTimeInMs(obj.getMarkDestroyedTimeInMs());
ttlReachedObjects.add(obj.getObjectId());
// generate the records which mark the expired objects as destroyed
records.add(new ApiMessageAndVersion(record, (short) 0));
// generate the records which listener reply for the object-destroy events
Expand All @@ -284,6 +287,9 @@ public ControllerResult<Void> checkS3ObjectsLifecycle() {
records.addAll(result.records());
});
});
if (!ttlReachedObjects.isEmpty()) {
log.info("objects TTL is reached, objects={}", ttlReachedObjects);
}
// check the mark destroyed objects
List<String> destroyedObjectKeys = this.markDestroyedObjects.stream()
.map(this.objectsMetadata::get)
Expand Down