Skip to content

refactor(tests): show RemoteCommandError when starting kakfa #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2024
Merged

refactor(tests): show RemoteCommandError when starting kakfa #866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
803d885
refactor(tests): show RemoteCommandError when starting kakfa
mooc9988 Mar 1, 2024
dff0851
remove testing codes
mooc9988 Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/kafkatest/services/kafka/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,17 @@ def alive(self, node):
return len(self.pids(node)) > 0

def start(self, add_principals="", nodes_to_skip=[], timeout_sec=60, **kwargs):
"""
Start the Kafka broker and wait until it registers its ID in ZooKeeper
Startup will be skipped for any nodes in nodes_to_skip. These nodes can be started later via add_broker
"""
try:
self.start0(add_principals=add_principals, nodes_to_skip=nodes_to_skip, timeout_sec=timeout_sec, **kwargs)
except RemoteCommandError as e:
self.logger.error("RemoteCommandError when starting Kafka service: %s", e)
raise

def start0(self, add_principals="", nodes_to_skip=[], timeout_sec=60, **kwargs):
"""
Start the Kafka broker and wait until it registers its ID in ZooKeeper
Startup will be skipped for any nodes in nodes_to_skip. These nodes can be started later via add_broker
Expand Down