feat: close #83; close #84; limit uploading objects due to s3 limits; use pooled bytebuffer; #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superhx
reviewed
Sep 11, 2023
| long indexBlockPosition = objectTailBuf.getLong(objectTailBuf.readableBytes() - 48); | ||
| int indexBlockSize = objectTailBuf.getInt(objectTailBuf.readableBytes() - 40); | ||
| if (indexBlockPosition + objectTailBuf.readableBytes() < objectSize) { | ||
| if (indexBlockPosition + indexBlockSize + 48 < objectSize) { |
Collaborator
There was a problem hiding this comment.
Replace magic value with named const value.
Contributor
Author
There was a problem hiding this comment.
fixed in the next commit.
| if (cachedBuf == null) { | ||
| // Case 1: create cache and add as the first item. | ||
| if (targetSize < minPartSize) { | ||
| cachedBuf = ByteBufAllocator.DEFAULT.compositeBuffer(); |
Contributor
Author
There was a problem hiding this comment.
fixed in the next commit.
| // cachedBuf not null | ||
| long combinedSize = cachedBufSize + targetSize; | ||
|
|
||
| if (combinedSize <= 2 * minPartSize) { |
Contributor
Author
There was a problem hiding this comment.
It is actually used to limit range reading. More comments will be added to explain this.
| } | ||
|
|
||
| @Override | ||
| public void copyWrite(String sourcePath, long start, long end) { |
Collaborator
There was a problem hiding this comment.
Extract write/copyWrite common code.
Contributor
Author
There was a problem hiding this comment.
handled in the next commit.
| if (targetSize < minPartSize) { | ||
| cachedBuf = ByteBufAllocator.DEFAULT.compositeBuffer(); | ||
| cachedBufSize = targetSize; | ||
| cachedBufLastAddCf = CompletableFuture.completedFuture(part).thenAccept(buf -> cachedBuf.addComponent(true, buf)); |
Contributor
Author
There was a problem hiding this comment.
more comments are added for it.
superhx
reviewed
Sep 11, 2023
| // Case 5: fill cachedBuf with source until it reaches minPartSize. Upload the cache and the rest of the source. | ||
| cachedBufLastAddCf = cachedBufLastAddCf | ||
| .thenRun(() -> cachedBuf.addComponent(true, part.slice(part.readerIndex(), (int) (minPartSize - cachedBufSize)).retain())); | ||
| handleWriteFuturePart(cachedBufLastAddCf, cachedBuf, System.nanoTime()); |
Collaborator
There was a problem hiding this comment.
Why two handleWriteFuturePart
Contributor
Author
There was a problem hiding this comment.
Only one is needed. Fixed in the next commit.
Signed-off-by: Curtis Wan <wcy9988@163.com>
superhx
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.